Software icon indicating copy to clipboard operation
Software copied to clipboard

Update deprecated GitHub actions and fix upload artifacts for simulated tests

Open williamckha opened this issue 1 year ago • 1 comments

Description

  • Update to actions/checkout@v4
  • Update to actions/update-artifact@v4 (v3 will be deprecated this November)
  • Fix incorrect actions/update-artifact path to simulated test proto logs

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [ ] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [ ] Remove all commented out code
  • [ ] Remove extra print statements: for example, those just used for testing
  • [ ] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

williamckha avatar Oct 02 '24 05:10 williamckha

look good. seems to work.

Mr-Anyone avatar Oct 05 '24 00:10 Mr-Anyone