Software
Software copied to clipboard
Final_speed and Target_spins_per_s
The full deletion of anything having to do with target_spin_rev_per_s and final_speed as being control params especially being updated
Testing involved building all files and watching thunderscope gameplay to ensure nothing seemed off
Resolved Issues
resolves #3145
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
- [x] Function & Class comments: All function definitions (usually in the
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class. - [x] Remove all commented out code
- [x] Remove extra print statements: for example, those just used for testing
- [x] Resolve all TODO's: All
TODO(or similar) statements should either be completed or associated with a github issue
Just if you could recheck it builds would be lovely thanks!