Software icon indicating copy to clipboard operation
Software copied to clipboard

[Robot Software] Support Variable Chip

Open Andrewyx opened this issue 1 year ago • 1 comments

Please fill out the following before requesting review on this PR

We can now chip varying distances with different powers up to a current arbitrary distance of 2m. More accurate at mid ranges.

Description

Testing Done

Robot Diagnostics + testing with ball & tape measure. Calibrated redis values for chipping.

Resolved Issues

Resolves #3012. Implements Dannon's branch.

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [ ] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [ ] Remove all commented out code
  • [ ] Remove extra print statements: for example, those just used for testing
  • [ ] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Andrewyx avatar Jul 17 '24 16:07 Andrewyx

Also seems like the code doesn't compile

itsarune avatar Jul 19 '24 00:07 itsarune

@Andrewyx Could you clean this up, retarget it for master and re-open this PR? We're going to keep #3012 open.

itsarune avatar Aug 15 '24 05:08 itsarune

@Andrewyx Could you clean this up, retarget it for master and re-open this PR? We're going to keep #3012 open.

Sounds good, I think this may have to change slightly to be compatible with a potential electrical redesign too.

Andrewyx avatar Aug 15 '24 06:08 Andrewyx