Refactor Protobuf conversion function names to be more consistent
Please fill out the following before requesting review on this PR
Description
Testing Done
Resolved Issues
Resolves #2901
Length Justification and Key Files to Review
https://github.com/UBC-Thunderbots/Software/pull/3014
It is the reviewers responsibility to also make sure every item here has been covered
- [ ] Function & Class comments: All function definitions (usually in the
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class. - [ ] Remove all commented out code
- [ ] Remove extra print statements: for example, those just used for testing
- [ ] Resolve all TODO's: All
TODO(or similar) statements should either be completed or associated with a github issue
I have run the ./fix_formatting.sh successfully, but nothing changed, is there any other way to solve the issue?
@Isabella373 Do you think you have time to finish this PR? The requested changes shouldn't take much time. Or should we close the PR for now?
I have run the ./fix_formatting.sh successfully, but nothing changed, is there any other way to solve the issue?
Hmm, maybe the code is formatted then. The CI check for code formatting has been a bit buggy recently, so the problem could be from that. If you push new changes, the check should run again and hopefully pass.
Stale, closing. Feel free to reopen after merging with master.