morphodict
morphodict copied to clipboard
Search failure for pimâtisiwina
There's an issue with some searches like pimâtisiwina.
Currently locally detected a list index out of range error, which should be checked on.
Issue relates to preverbs. Failure currently at https://github.com/UAlbertaALTLab/morphodict/blob/5440fda28627dbe87ca69a4d32e90eff32b63ea2/src/CreeDictionary/API/search/presentation.py#L509
when tag='PV/mahti+'.
This can be solved in two ways:
- Default to unfound result when
entries[0]fails, would provide some results whenever this code fails, deploying that as a temporary fix. - @aarppe Main problem is that there is no entry in
importjsonformahtithat hasinflectional_category="IPV", as expected by https://github.com/UAlbertaALTLab/morphodict/blob/5440fda28627dbe87ca69a4d32e90eff32b63ea2/src/CreeDictionary/API/search/presentation.py#L501 . Currently there are entries withIPC,IPJ,IPH, andV. Should these all be accepted instead ofIPV(or justV?)
Immediate issue has been fixed in production with the hotfix, but decision on handling Preverbs that are not an IPV remains a concern that needs to be addressed before closing the issue.