morphodict icon indicating copy to clipboard operation
morphodict copied to clipboard

Search failure for pimâtisiwina

Open fbanados opened this issue 1 year ago • 2 comments

There's an issue with some searches like pimâtisiwina.

Currently locally detected a list index out of range error, which should be checked on.

fbanados avatar Oct 08 '24 19:10 fbanados

Issue relates to preverbs. Failure currently at https://github.com/UAlbertaALTLab/morphodict/blob/5440fda28627dbe87ca69a4d32e90eff32b63ea2/src/CreeDictionary/API/search/presentation.py#L509

when tag='PV/mahti+'.

This can be solved in two ways:

  • Default to unfound result when entries[0] fails, would provide some results whenever this code fails, deploying that as a temporary fix.
  • @aarppe Main problem is that there is no entry in importjson for mahti that has inflectional_category="IPV", as expected by https://github.com/UAlbertaALTLab/morphodict/blob/5440fda28627dbe87ca69a4d32e90eff32b63ea2/src/CreeDictionary/API/search/presentation.py#L501 . Currently there are entries with IPC, IPJ, IPH, and V. Should these all be accepted instead of IPV (or just V?)

fbanados avatar Oct 08 '24 20:10 fbanados

Immediate issue has been fixed in production with the hotfix, but decision on handling Preverbs that are not an IPV remains a concern that needs to be addressed before closing the issue.

fbanados avatar Oct 09 '24 00:10 fbanados