Hurl icon indicating copy to clipboard operation
Hurl copied to clipboard

[DEMO] Loads of suggestions

Open Jay-o-Way opened this issue 1 year ago • 3 comments
trafficstars

Hi,

I took the liberty to make some changes, hoping to help. Of course, this is how "I" would do things. It's your project and you are free to accept everything you want. Also, it might not be perfect right now, please do double-check.

Comments / details

  • TO-DO: check why IsEnabled="{Binding UseCustomRule.IsChecked}" doesn't work ⚠️
  • General tidy-up of XAML and layouts, incl. window sizes
  • Use a CheckBox for optional use of custom rule; merged the CS code together and use IF statement
  • Use an InfoBar to display the test result
  • Feel free to ask for more info

Screenshots

image image image

Jay-o-Way avatar Mar 20 '24 18:03 Jay-o-Way

Woah, Thanks for this.... I can use your PR as starting phase to work on next set of stuff.

Of course, this is how "I" would do things. It's your project and you are free to accept everything you want

😅 yeh, I am kind of opinionated about some stuff, but I do like some of the things here, which I will salvage out of this.

U-C-S avatar Mar 21 '24 16:03 U-C-S

Wouldn't this PR create conflicts with #114 once either of these are merged ??

U-C-S avatar Apr 18 '24 20:04 U-C-S

Oh yes. Definitely. This is a PR I made in a rather short time, mostly to demo ideas, as I would approach. You also have your personal ideas for the "re-write" milestone. In any case, it's always better to be more targeted with PRs.

Jay-o-Way avatar Apr 18 '24 21:04 Jay-o-Way