Hurl icon indicating copy to clipboard operation
Hurl copied to clipboard

Published 20 hours ago • verified publisher icon U-C-S

Support for sub-domain rules within domain rule type

Open Jay-o-Way opened this issue 1 year ago • 2 comments
trafficstars

image

Jay-o-Way avatar Mar 19 '24 12:03 Jay-o-Way

should it work with docs.github.com domain rule , then it's working as intended. atleast for now.

Honestly I was confused about handling the case of sub-domains. Maybe In future, I can have extra option for also including sub-domains as a checkbox.

U-C-S avatar Mar 19 '24 14:03 U-C-S

I assumed that the rule would capture the top domain. Note that the example of *.domain.com literally implies a sub-domain 🤓

Jay-o-Way avatar Mar 19 '24 15:03 Jay-o-Way