Photon-v2 icon indicating copy to clipboard operation
Photon-v2 copied to clipboard

Most of the surface optics do not respond to SurfaceElemental in calcBsdf()

Open TzuChieh opened this issue 5 years ago • 1 comments

Need to do the following:

  • make them respond
  • check for missed ones in other methods
  • properly test this (integration test maybe?)

TzuChieh avatar Apr 12 '19 09:04 TzuChieh

They do. It was a false positive alert. Since input should not provide invalid elemental ID in the first place (>= numElementals).

Now the steps are

  • assert ID range

  • assert this

  • document this

TzuChieh avatar Apr 12 '19 10:04 TzuChieh

  • [x] Check if this is still an issue
  • [x] Document the use of elemental

TzuChieh avatar Jan 29 '24 19:01 TzuChieh