YoutubeDL-Material
YoutubeDL-Material copied to clipboard
Repo cleanup
I suggest the following changes to make the repo a little friendlier to work with
- [x] #625
- [ ] #626
- [ ] #660
- [x] Remove youtubedl-material-docker.zip from the releases page and instead make a README/wiki page showing the recommended docker-compose file (see #143 )
- [x] Remove *.exe files
$ git ls-files '*.exe'
backend/aria2c.exe
backend/ffmpeg.exe
backend/ffplay.exe
backend/ffprobe.exe
backend/youtube-dl.exe
(Feel free to edit this issue and discuss below) Cheers!
The biggest annoyance is that those blobs are still in the git repo forever.
If done right, this shouldn't be a problem: https://chrisshort.net/permanently-remove-any-record-of-a-file-from-git/ https://help.github.com/en/github/managing-large-files/removing-files-from-a-repositorys-history (But please be careful with these commands)
The biggest annoyance is that those blobs are still in the git repo forever.
If done right, this shouldn't be a problem:
I've had to do that before. I committed an admin Firebase API key to a public repo before (not this one), found out when Google emailed me their crawler found it. Anyways I'm sloppy enough that I have experience there :)
I can also take care of that before closing out this issue. I'm on board with everything in here, if anyone wants to take care of any of these items (besides the new repo work) feel free!
Slightly related to https://github.com/Tzahi12345/YoutubeDL-Material/issues/130
Regarding this:
Download button in the application for the browser extension should download the newest version of the browser extension from the releases page
This should work rather well for when the browser name can be uniquely identified as being one of the things we specifically release for, but what if the user's browser is a browser based on any such browser?
Waterfox, Edge Chromium, Brave, etc... Hard-code all those cases or do browsers provide a way to query which mainline browser they are based on, as in which extension-type they target? I'm really out of the loop, but this should be considered.
Beyond that we should also link to the browser's extension catalog if we have a presence there. Added bonus: downloads over there also work to improve our SEO and overall adoption I think.