vscode-theme-generator icon indicating copy to clipboard operation
vscode-theme-generator copied to clipboard

Finalize and commit to API

Open Tyriar opened this issue 7 years ago • 3 comments

Some open questions:

  • Should color1, color2, etc. be named accent1, accent2 or something more specific?
  • How do we mitigate heaps of language specific syntax color types such as markdownQuote, cssTag, etc.

Tyriar avatar Apr 05 '17 16:04 Tyriar

First of all, very cool project.

I think this is just something where you need to take a different approach to coloring things. Don't think of "variables are red" think of "variables are secondary accent color, keywords are primary accent color, comments are the muted color".

In my "Uno Due Tre" color scheme I generate all the syntax colors from just 3 hue values.

image

This may be more limited than what you want, but I find it's actually worked out quite well for me.

wavebeem avatar Jun 15 '17 04:06 wavebeem

@wavebeem I like it, it's a pretty big change though.

I had an idea to have "generator templates" which would create themes using different source colors and maybe have different features, such as having same background color for most things vs more contrast across the workbench, or a palette of a different size.

Tyriar avatar Jun 16 '17 14:06 Tyriar

I could totally see two extra keys:

  • uiStyle: "light" | "dark" | high-contrast"
  • codeStyle: "2-tone" | "3-tone" | "many-colors"

So you could specify a few strategies for the UI theme vs the code theme. uiStyle could read from the background/foreground keys, and codeStyle could maybe read from an array of colors, which are sorted in order of importance or something? Just a thought.

wavebeem avatar Jun 16 '17 16:06 wavebeem