Aegisub icon indicating copy to clipboard operation
Aegisub copied to clipboard

meson: patch ffms2 to disable audio gap filling

Open CoffeeFlux opened this issue 4 years ago • 6 comments

CoffeeFlux avatar Jan 10 '21 08:01 CoffeeFlux

This one is a little more complicated, and I was convinced that I should take another shot at fixing it properly.

CoffeeFlux avatar May 07 '21 15:05 CoffeeFlux

Does this issue really matter? What will happen if we don't fix this.

inkydragon avatar Jul 09 '21 12:07 inkydragon

It does, unfortunately. This bug is a huge show-stopper for a lot of people, especially because it's not something they're likely to notice until they've already timed a large portion of the episode.

On certain videos the ffms2 gap-filling code overcorrects and the video timing will be subtly off, and it will get worse the longer the video plays. This means at playback the timing seems fine at first but progressively decays until it can be off by multiple seconds.

I'll also take a look at your PR in the next couple days—sorry for the delay, I've been out of town.

CoffeeFlux avatar Jul 09 '21 15:07 CoffeeFlux

Relax and review the pull request at your own pace.

I want to know how to reproduce the problem.

According to my understanding, the problem is that Making subtitles in AEG work fine, but when subtitles are loaded with other players, the subtitle and the video is out of sync

inkydragon avatar Jul 09 '21 16:07 inkydragon

@CoffeeFlux

Some thoughts: If we can't fix this in the short term, perhaps we should merge our present work (TypesettingTools/Aegisub) into (Aegisub/Aegisub).

This allows us to do development work in Aegisub/Aegisub. Everyone can collaborate in one place. Maybe this will help solve the issue as well.

Of course, we won't release a new version until this issue is resolved.


aegisub.org is back. I think it's time to re-activate Aegisub/Aegisub as well.

inkydragon avatar Feb 14 '23 14:02 inkydragon