TypesettingTools
Adjust the default (=minimum) width of the style editor
After thinking for a while longer, I considered deeper questions which confused me again. What behavior do we expect the dialog box to exhibit when it is "stretched and widened"? I feel that the behavior prior to this PR, scaling these two spinboxes proportionally to the combobox, is reasonable.
The code is ready for review, although the commit message appears verbose and warrants discussion. Perhaps a more concise explanation of the rationale behind this change could be provided.
I actually prefer the suggestion you had before, i.e. just giving the combobox a proportion of 0 and making only the two spin controls expand with the dialog. That helps visually separate the combobox from the spin controls a bit, and is more likely to be what the user wants.
And yes, I'm not really a fan of overly verbose LLM-generated commit messages. Commit messages should explain why a change was made (like e.g. what bugs it fixes) and why a specific solution was chosen over other options, but they don't need to explain the code itself - if the code needs to be explained, that should happen in comments.
The appearance at various proportions are presented hereby to shed the burden of commit messages by referencing this comment.
| Default | Stretched | |
|---|---|---|
(Before our PR) spinCtrl and non-editable comboBox proportion = 1 |
||
spinCtrl and non-editable comboBox proportion = 0 |
||
spinCtrl proportion = 1, non-editable comboBox proportion = 0 |
||
spinCtrl proportion = 0, non-editable comboBox proportion = 1 |
|
|
spinCtrl and non-editable comboBox proportion = bestWidth |
||
Border style comboBox proportion = 0, anything else proportion = 1 |