What happens if the strings in `log_levels` are localized?

Open 0tkl opened this issue 2 weeks ago • 1 comments

https://github.com/TypesettingTools/Aegisub/blob/39f691273e9f47ffcccf8eaf213c457d1c85bcab/src/preferences.cpp#L461-L466

https://github.com/TypesettingTools/Aegisub/blob/39f691273e9f47ffcccf8eaf213c457d1c85bcab/src/ffmpegsource_common.cpp#L141-L161

Could this result in “no matter which option is set, the final effect is always quiet”?

Dec 04 '25 08:12 0tkl

Indeed, this change was broken. I had the wrong assumption that OptionChoice always resulted in an integer option, but it can actually represent both string and integer options, depending on what type is set in default_config.json.

Still, I don't think it's wrong to make the log options translatable. The translation call just needs to be moved to OptionChoice. I will fix this soon.

Dec 04 '25 11:12 arch1t3cht

Fixed in a63edfe8bbf146c89744a3441907541ba7d8ed25.

Dec 22 '25 13:12 arch1t3cht