Aegisub icon indicating copy to clipboard operation
Aegisub copied to clipboard
verified publisher icon TypesettingTools

`GetLanguageInfo()->CanonicalName` not as expected

Open 0tkl opened this issue 1 year ago • 2 comments

https://github.com/TypesettingTools/Aegisub/blob/3a07376ef9b09fb93a84f289865784f8175a6a5e/src/aegisublocale.cpp#L96-L102

Install Aegisub on a ko-KR locale Windows computer, and open Aegisub for the first time. The Korean language does not appear at the top of the list. I'm not sure which of the languages already supported by Aegisub still affected by this bug.

캡처1

0tkl avatar Dec 17 '24 07:12 0tkl

Turkish language is also not at the top of the list. But I think this happens with all languages. image

KerimDemirkaynak avatar Jan 02 '25 10:01 KerimDemirkaynak

Having tested it for a bit, I now suspect that AegisubLocale::HasLanguage() is working correctly, so AegisubApp::OnInit() is likely able to correctly select the appropriate UI language. The bug probably lies solely within AegisubLocale::PickLanguage().

https://github.com/TypesettingTools/Aegisub/blob/a5a7bc58f2552a2ee2283c445d6e7c68e57d898c/src/main.cpp#L230-L236

0tkl avatar Jan 24 '25 14:01 0tkl