Aegisub icon indicating copy to clipboard operation
Aegisub copied to clipboard

Add flatpak build

Open Totto16 opened this issue 2 years ago • 4 comments

This provides a flatpak manifest to build aegisub as flatpak application

  • it adds a CI that builds it
  • it also adds DependencyControl (I find it helpful, to include that in a flatpak build, but ofc it could be changed)
  • it fixes some names, that require a certain schema on flatpak (icons, app_name etc.)
  • this builds the dependencies like boost, wxWidgets beforehand with their own build system, mainly due to local development concerns, but also to be sure, that no bug occurs in the meson conversion of these dependencies
  • it uses
    • lua 5.1
    • wxWidgets 3.2.3
    • boost 1.83.0
    • libass 0.17.1 (this builds from the original repo, but since this manifest is a little bit older, where the meson port didn't have these adjustments, it could be changed to that

Totto16 avatar Dec 04 '23 00:12 Totto16

You might want to look at https://github.com/Aegisub/Aegisub/issues/336.

I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

zefr0x avatar Dec 11 '23 01:12 zefr0x

You might want to look at Aegisub#336.

I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Your package seems much more sophisticated, but since the main work for Aegisub/Aegisub is done here, and with meson as build system, with the version of the libraries, that are used here, and this is eventually merged into that repo, it would be better to build on this repo, maybe we could merge the manifests in some way 🤔

Totto16 avatar Dec 11 '23 01:12 Totto16

You might want to look at Aegisub#336. I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Your package seems much more sophisticated, but since the main work for Aegisub/Aegisub is done here, and with meson as build system, with the version of the libraries, that are used here, and this is eventually merged into that repo, it would be better to build on this repo, maybe we could merge the manifests in some way 🤔

I don't think that Flathub would accept a fork with no official stable release.

Any way it's easy to use the new build system, noting huge need to be changed (I even have it commented in the manifest).

If Flathub don't have any problems I will relay on TypesettingTools/Aegisub. I will ask them when I open a pull request.

zefr0x avatar Dec 11 '23 02:12 zefr0x

You might want to look at Aegisub#336. I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Your package seems much more sophisticated, but since the main work for Aegisub/Aegisub is done here, and with meson as build system, with the version of the libraries, that are used here, and this is eventually merged into that repo, it would be better to build on this repo, maybe we could merge the manifests in some way 🤔

I don't think that Flathub would accept a fork with no official stable release.

Any way it's easy to use the new build system, noting huge need to be changed (I even have it commented in the manifest).

If Flathub don't have any problems I will relay on TypesettingTools/Aegisub. I will ask them when I open a pull request.

The only main difference between the meson and the autotools version is the flatpak specific things, like .desktop file with name (not aegisub but "org.aegisub.Aegisub") and the icons names, the rest is nearly the same, since I also used the native build systems for the dependencies, but not that many specific options etc. I also added Dependency control, which could be controversial. IMO it's much more concise, to modfiy a few lines of the build system than patching the original code up, to rename these etc. Meson is better integrated than autotools in the flatpak-builder etc.

Totto16 avatar Dec 11 '23 02:12 Totto16

You might want to look at Aegisub#336.

I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Update: Flatpak package published at flathub/org.aegisub.Aegisub and can be found at https://flathub.org/apps/org.aegisub.Aegisub.

Soon i will update it to 3.4

zefr0x avatar Jan 03 '25 13:01 zefr0x

You might want to look at Aegisub#336. I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub

Update: Flatpak package published at flathub/org.aegisub.Aegisub and can be found at https://flathub.org/apps/org.aegisub.Aegisub.

Soon i will update it to 3.4

Yeah I saw that, but forgot to close this 😓

Totto16 avatar Jan 03 '25 23:01 Totto16

Close in favor of https://github.com/Aegisub/Aegisub/issues/336

Totto16 avatar Jan 03 '25 23:01 Totto16