typedoc icon indicating copy to clipboard operation
typedoc copied to clipboard

feat: Make `mappings` and `getMapping` public

Open NikolaRHristov opened this issue 1 year ago • 4 comments

Allows for the overriding of mappings, so that they can be overriden by child themes that extend DefaultTheme.

This will resolve current issues such as https://github.com/TypeStrong/typedoc/issues/2111 with the creation of a simple theme like in https://github.com/NikolaRHristov/TypeScriptESBuild/blob/main/Source/Class/Theme.ts

NikolaRHristov avatar Sep 30 '23 18:09 NikolaRHristov

I just noticed I can override buildUrls, nevermind. 😁 Still useful though. Will leave it open if you want to merge.

NikolaRHristov avatar Sep 30 '23 18:09 NikolaRHristov

I'm not sure I want to merge this -- I've never liked how the URL building was implemented, and making this part of the public API seems like a step in the wrong direction...

I've been experimenting with alternative generation schemes on the beta branch, but am not fully happy with it yet

Gerrit0 avatar Oct 15 '23 18:10 Gerrit0

Should I close the PR?

NikolaRHristov avatar Oct 16 '23 08:10 NikolaRHristov

Feel free to leave it open for now, if I vent get the rework into a state I'm happy with, I'll reconsider merging :)

Gerrit0 avatar Oct 16 '23 14:10 Gerrit0