ts-mockito icon indicating copy to clipboard operation
ts-mockito copied to clipboard

Johanblumenberg matcher types

Open LironHazan opened this issue 4 years ago • 4 comments
trafficstars

LironHazan avatar Sep 28 '21 08:09 LironHazan

Codecov Report

Merging #8 (3026558) into master (25b8f1d) will increase coverage by 0.23%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   93.41%   93.64%   +0.23%     
==========================================
  Files          34       36       +2     
  Lines         653      677      +24     
  Branches       80       84       +4     
==========================================
+ Hits          610      634      +24     
  Misses         30       30              
  Partials       13       13              
Impacted Files Coverage Δ
src/matcher/type/EndsWithMatcher.ts 100.00% <100.00%> (ø)
src/matcher/type/StartsWithMatcher.ts 100.00% <100.00%> (ø)
src/ts-mockito.ts 97.01% <100.00%> (+0.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25b8f1d...3026558. Read the comment docs.

codecov-commenter avatar Sep 28 '21 09:09 codecov-commenter

@cspotcode I fixed some of the types in the original PR, a matcher function should return a matcher type not any, the tests were actually expected a matcher. Regards deepEquality should check if there's a chance of breaking changes as it was loose as well (retuned any) and there's a test that I didn't understand what it aims to achieve, maybe you'll know? (see in my comments) generally I feel there's a lot of place in improving the typing in the project.. I ran the tests, all passed.

LironHazan avatar Sep 28 '21 10:09 LironHazan

Is there a reason to no merge this? besides conflicts?

roypeled avatar Jul 14 '24 13:07 roypeled

Is there a reason to no merge this? besides conflicts?

@roypeled Not that I remember

LironHazan avatar Jul 20 '24 06:07 LironHazan