ts-mockito
ts-mockito copied to clipboard
Johanblumenberg matcher types
Codecov Report
Merging #8 (3026558) into master (25b8f1d) will increase coverage by
0.23%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 93.41% 93.64% +0.23%
==========================================
Files 34 36 +2
Lines 653 677 +24
Branches 80 84 +4
==========================================
+ Hits 610 634 +24
Misses 30 30
Partials 13 13
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/matcher/type/EndsWithMatcher.ts | 100.00% <100.00%> (ø) |
|
| src/matcher/type/StartsWithMatcher.ts | 100.00% <100.00%> (ø) |
|
| src/ts-mockito.ts | 97.01% <100.00%> (+0.29%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 25b8f1d...3026558. Read the comment docs.
@cspotcode I fixed some of the types in the original PR, a matcher function should return a matcher type not any, the tests were actually expected a matcher. Regards deepEquality should check if there's a chance of breaking changes as it was loose as well (retuned any) and there's a test that I didn't understand what it aims to achieve, maybe you'll know? (see in my comments) generally I feel there's a lot of place in improving the typing in the project.. I ran the tests, all passed.
Is there a reason to no merge this? besides conflicts?
Is there a reason to no merge this? besides conflicts?
@roypeled Not that I remember