fork-ts-checker-webpack-plugin icon indicating copy to clipboard operation
fork-ts-checker-webpack-plugin copied to clipboard

Clarify "No errors found." message

Open cben opened this issue 2 years ago • 2 comments

A really minor usability tweak, subjective, up to you if you like it.

In the context of webpack-dev-server, there are 2 async build processes, which may report success/failure:

  • webpack bundle:
    • webpack 5.72.0 compiled with 2 errors in 5492 ms,
    • webpack 5.72.0 compiled successfully in 55345 ms are self-explaining.

There is sometimes a cyan "Type-checking in progress..." between them, but not always.

  • TypeScript checking, which may arrive later:
    • when typescript fails, it starts with non-specific red "ERROR in ./src/..." but next line start with TS error code e.g. TS6133: , so clear enough.
    • when typescript succeeds, the green "No errors found." message may arrive later, and doesn't explain it's specifically what kind of errors. :point_left:

This PR tweaks the last case to say "No typescript errors found." for clarity.

Screenshot from 2023-10-29 15-42-45

cben avatar Apr 16 '23 14:04 cben

Maybe it would make more sense to just say "No typescript errors found."?

piotr-oles avatar Oct 29 '23 10:10 piotr-oles

Maybe it would make more sense to just say "No typescript errors found."?

Done, PTAL.

UPDATE: now also updated waitForNoErrors test helper. needs approval to re-run CI?

cben avatar Oct 29 '23 13:10 cben