fork-ts-checker-webpack-plugin icon indicating copy to clipboard operation
fork-ts-checker-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon TypeStrong

fix: vue2.7 SFC compiler.parse error v6

Open iceprosurface opened this issue 2 years ago • 6 comments

see #765

iceprosurface avatar Jul 19 '22 05:07 iceprosurface

I think we should use vue's semantic version to check whether vue is vue2.7 | vue3 | vue2.

VueTemplateCompilerV2_7 & isVueTemplateCompilerV2_7OrV3 & isVueTemplateCompilerV2 cannot be able to a safely check vue versions.

From: https://github.com/vuejs/vue/issues/12679#issuecomment-1189778234

iceprosurface avatar Jul 21 '22 01:07 iceprosurface

Feel free to change that. This would not prevent this issue from happening - they introduced breaking change to their API without a major bump ;)

piotr-oles avatar Jul 21 '22 07:07 piotr-oles

I don‘t know why e2e was fail on github action

it works well on my mac.

image

ohh, There is so many lock file changes,may i append all lock file changes? image

iceprosurface avatar Jul 22 '22 02:07 iceprosurface

Yes, the locks file in git is not a great DX - that's why I changed it in the v7. You can commit these lock files.

piotr-oles avatar Jul 22 '22 08:07 piotr-oles

Hi, I've noticed also the missing type-checks for [email protected], which is unfortunate because the prod-build is not stopping anymore if there are any type errors. Is this PR going to be merged soon-ish?

rs3d avatar Jul 28 '22 11:07 rs3d

Thanks @iceprosurface for the PR! I've been trying to figure out this bug all morning.

While we're waiting for this to get merged, has anyone figured out a workaround?

mohanyin avatar Sep 21 '22 20:09 mohanyin

I'm dropping support for Vue.js - there is no clean API in TypeScript to support it and I don't have time to maintain it as current workaround is hacky and buggy :/

piotr-oles avatar Mar 05 '23 20:03 piotr-oles