app playground: search never terminates

[rubenfiszel]

Using the app playground, adding: ...getSearchServiceOverride()

and even adding in the worker factory:

                LocalFileSearchWorker: () =>
                    new Worker(
                        new URL(
                            "@codingame/monaco-vscode-search-service-override/worker",
                            import.meta.url
                        ),
                        { type: "module" }
                    ),

1. LocalFileSearchWorker never seems to be loaded
2. The search never terminates even though it displays some result (search icon shows a loader and a progress bar is forever loading at top)
3. Only the search from opened tab shows in the search result, not files of the workspace that have not been opened in the editor

[CGNonofr]

LocalFileSearchWorker never seems to be loaded

It's only used for local search (ie using the HTMLFileSystemProvider as main file fs provider)

The search never terminates even though it displays some result (search icon shows a loader and a progress bar is forever loading at top)

Yes, the only existing implementations are the local (see 1) one and the node one (via a worker). When using the lib, no implementation exists on the virtual filesystem. You can implement it yourself though, like what was done on the monaco-vscode-api demo ; it only relies on open models though, so it can probably be improved.

[kaisalmen]

Issue review before new release. I will close this now. feat: add workspace search with VSCode FS is now available.