Tyler Rick

Results 123 comments of Tyler Rick

I found the `test` option that you can pass to `spam?`. Perhaps this should be documented in the Readme like it is in rakismet. But I still think it would...

I was wanting this feature too today. +1

Any word on upgrading this for D3 4.x? It seems to cause errors when I tried installing it (with npm) alongside D3 4.x. I would love to use cubism but...

BTW, found a couple options for horizon charts in D3 4: - http://kmandov.github.io/d3-horizon-chart/ - https://codepen.io/whitelynx/pen/dpbvPb But they seriously don't look or work as well as Cubism. :slightly_frowning_face: For example, it...

Tried changing the d3 script tag on (a copy of) https://bost.ocks.org/mike/cubism/intro/demo-stocks.html (for example) to: ``` ``` and it throws a bunch of JS errors. Cubism makes such beautiful charts (and...

Since a picture is worth a 800 words, here's what the error looked like before: ![image](https://cloud.githubusercontent.com/assets/14151/19457170/f4a890cc-9479-11e6-9e36-cc0eab96a44d.png) and here's how the same error shows up now: ![image](https://cloud.githubusercontent.com/assets/14151/19457153/d7b08b46-9479-11e6-8307-36ee8a80dbb7.png)

Does this look okay? Anything I need to do to get it merged in?

> As you may see, `**opts` delegation isn't really the best option. See https://eregon.me/blog/2021/02/13/correct-delegation-in-ruby-2-27-3.html for more details. > > A correct way to fix this is: ![image](https://user-images.githubusercontent.com/6916/171338518-2d01739b-9edb-428e-8610-2c0829bd13f1.png) Good catch —...

This is a good idea! Can we remove the `stale` label and revive this PR? Having a `ApplicationStorageController` which inherits from `ActiveStorage::BaseController` approach sounds the most similar to the usual...