tyk icon indicating copy to clipboard operation
tyk copied to clipboard

[TT-12317][PoC] allow validating CA during mTLS

Open jeffy-mathew opened this issue 1 year ago • 2 comments

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • [ ] I ensured that the documentation is up to date
  • [ ] I explained why this PR updates go.mod in detail with reasoning why it's required
  • [ ] I would like a code coverage CI quality gate exception and have explained why

jeffy-mathew avatar Jun 07 '24 13:06 jeffy-mathew

API Changes

--- prev.txt	2024-07-09 13:06:10.588182998 +0000
+++ current.txt	2024-07-09 13:06:07.356154491 +0000
@@ -8027,6 +8027,7 @@
 
 type CertificateCheckMW struct {
 	*BaseMiddleware
+	// Has unexported fields.
 }
     CertificateCheckMW is used if domain was not detected or multiple APIs bind
     on the same domain. In this case authentification check happens not on TLS

github-actions[bot] avatar Jun 07 '24 13:06 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 07 '24 14:06 sonarqubecloud[bot]

feature implemented in https://github.com/TykTechnologies/tyk/pull/6405

jeffy-mathew avatar Aug 13 '24 07:08 jeffy-mathew