tyk icon indicating copy to clipboard operation
tyk copied to clipboard

Published 20 hours ago • verified publisher icon TykTechnologies

[TT-6402]: Fix arm64 plugin builds and try an approach without go mod vendor for plugin compiler

Open asutosh opened this issue 2 years ago • 9 comments

Description

Fix cross compiling of arm64 builds using plugin compiler image. Also try out the approach mentioned here: https://github.com/TykTechnologies/tyk/pull/3998#issuecomment-1233544087

asutosh avatar Sep 06 '22 12:09 asutosh

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit:
Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Sep 06 '22 12:09 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: bdcdcf44a171b93d1fd47cff9d110f87cf21ad59 Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Sep 07 '22 08:09 Tyk-ITS

API tests result: skipped :no_entry_sign: Branch used: refs/pull/4287/merge Commit: dfab6e34cb3752d53bec1e0b8661ac2fb5183659 Triggered by: pull_request (@asutosh) Execution page

buger avatar Sep 12 '22 11:09 buger

API tests result: skipped :no_entry_sign: Branch used: refs/pull/4287/merge Commit: dfab6e34cb3752d53bec1e0b8661ac2fb5183659 Triggered by: pull_request (@asutosh) Execution page

buger avatar Sep 12 '22 12:09 buger

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 8c1403ff6e23adb112e1c5fbf2cebacc842a0048 Triggered by: pull_request (@asutosh) Execution page

buger avatar Sep 12 '22 13:09 buger

Are the changes for vendoring dependencies part of fixing arm64 plugin builds or are they unrelated? If yes, needs a review from @jeffy-mathew or @sredxny from the dev side.

alephnull avatar Sep 13 '22 08:09 alephnull

@alephnull Yes, they are. The build script had to be changed - so included both changes together. I'll add them as reviewers.

asutosh avatar Sep 13 '22 09:09 asutosh

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 14 '22 09:09 sonarqubecloud[bot]

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 86a7b137004f899a29761ab343205bdb0618e150 Triggered by: pull_request (@asutosh) Execution page

buger avatar Sep 14 '22 09:09 buger

:boom: CI tests failed :see_no_evil:

git-state

all ok

Please look at the run or in the Checks tab.

github-actions[bot] avatar Nov 14 '22 17:11 github-actions[bot]

API tests result: failure :no_entry_sign: Branch used: refs/pull/4287/merge Commit: 95d239c34dd3e35ea6e7104ecbab391e44c5287d Triggered by: pull_request (@sedkis) Execution page

Tyk-ITS avatar Nov 14 '22 17:11 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 8e185bd82e48b6b03c5cd6fc149a372f12081746 Triggered by: pull_request (@sedkis) Execution page

Tyk-ITS avatar Dec 20 '22 14:12 Tyk-ITS

Thanks @sedkis for this. There are a couple of admin things due to which I have disabled the auto-merge:

  • master has been merged into this branch instead of rebasing which will be a problem when propagating this code to release branches
  • it is not clear if you are proposing an alternate implementation to what @asutosh proposed

So, could I ask you to,

  • re-work this branch with master rebased instead of a branch
  • if you proposing an alternative implementation, create a another PR, based on this branch so that it is clear what is being proposed
  • if an alternative is being proposed, please also add some context in the PR as to why it is better as the build script is already too sublime for mere mortals

If you need some help with any of the above, please feel free to comment here or bring it up on Slack.

alephnull avatar Dec 20 '22 16:12 alephnull

@alephnull It's not a re-implementation - the branch was updated with master by merge commits. I'll rebase my local changes on this branch to the current master and force push - that should take care of the merge commits.

asutosh avatar Dec 21 '22 07:12 asutosh

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 039c3cb1b9231c4cb83ad3f559d5998e52455e33 Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Dec 21 '22 07:12 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 0b60f2ac65014e1a14b484df33bc7d7f472641d6 Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Jan 04 '23 06:01 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: d27bc9cb418b9566d99b43a30ea3c6a34afb0254 Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Jan 10 '23 06:01 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 21924985078b2c059c86bbeae71ff0dcd8f7f67c Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Jan 10 '23 06:01 Tyk-ITS

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 34046812d9f94d22f6e5bfdab7c9a7aed17c3535 Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Jan 11 '23 07:01 Tyk-ITS

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jan 31 '23 10:01 sonarqubecloud[bot]

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 446cd9f2aa6607ef849d196a45baf8428d2d037a Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Jan 31 '23 10:01 Tyk-ITS

:boom: CI tests failed :see_no_evil:

git-state

all ok

Please look at the run or in the Checks tab.

github-actions[bot] avatar Feb 01 '23 07:02 github-actions[bot]

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: fa91646b0baf8ab82d5a8033dbbb984a8d2f286c Triggered by: pull_request (@buger) Execution page

Tyk-ITS avatar Feb 01 '23 07:02 Tyk-ITS

:boom: CI tests failed :see_no_evil:

git-state

all ok

Please look at the run or in the Checks tab.

github-actions[bot] avatar Feb 02 '23 06:02 github-actions[bot]

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 2d0e9f967a6cfbec02dc45e0c24c983e9908a804 Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Feb 02 '23 06:02 Tyk-ITS

:boom: CI tests failed :see_no_evil:

git-state

all ok

Please look at the run or in the Checks tab.

github-actions[bot] avatar Feb 03 '23 08:02 github-actions[bot]

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: c57da6c89aa0551a90c75fade933eb3e66f2d5cf Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Feb 03 '23 08:02 Tyk-ITS

:boom: CI tests failed :see_no_evil:

git-state

all ok

Please look at the run or in the Checks tab.

github-actions[bot] avatar Feb 03 '23 10:02 github-actions[bot]

:boom: CI tests failed :see_no_evil:

git-state

all ok

Please look at the run or in the Checks tab.

github-actions[bot] avatar Feb 03 '23 14:02 github-actions[bot]

API tests result: success :white_check_mark: Branch used: refs/pull/4287/merge Commit: 384af02bda48704415e1f341c40c29c8f2907375 Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Feb 03 '23 15:02 Tyk-ITS