tyk icon indicating copy to clipboard operation
tyk copied to clipboard

[TD-959]: Add automation for running go mod tidy in release branches.

Open asutosh opened this issue 2 years ago • 3 comments

Description

Add a GHA workflow that will update go.mod and go.sum after running go mod tidy on the current release branches.

Related Issue

TD-959

Motivation and Context

More details are in the associated issue.

How This Has Been Tested

Can be tested once it's approved and merged to the appropriate release branches, and a commit is pushed to these branches.

asutosh avatar Apr 07 '22 16:04 asutosh

API tests result: success :white_check_mark: Branch used: refs/pull/3999/merge Commit:
Triggered by: pull_request (@asutosh) Execution page

Tyk-ITS avatar Apr 07 '22 17:04 Tyk-ITS

@alephnull we did consider the pre-hook option, but this won't work in case the release but (/release command) is used to port changes to a release branch. Unless there's a way to configure the bot to call the pre-commit hook. Also I'm concerned that hooks are not enforceable ( on non enterprise gh orgs) , so we'll need to trust on ppl goodwill and memory. I would say lets create the pre-commit web-hook script as main tool but leave the workflow as fallback mechanism

ermirizio avatar Apr 11 '22 13:04 ermirizio

My point is that it is too late to run such basic things after cherry picking a commit to a release branch.

alephnull avatar Apr 11 '22 13:04 alephnull