[TT-1004] Implement PKCE on top of the update Osin fork (part of TT-998)

[joshblakeley]

Fix https://tyktech.atlassian.net/browse/TT-1004

Description

The osin library is used by Tyk for building it's internal OAuth2.0 server. The current import uses a fork in the lonelycode org that is very old and misses out on the updates made to the original openshift/osin lib in the intervening years. i.e. PKCE support OOTB for Auth code flows etc

Because we need some custom changes to support out data model in Tyk we have created a new openshift fork and changed what we needed to for Tyk compatibility. We then use the TykTechnologies/osin fork as our osin library going forward.

While were here because we have underlying PKCE support in the library we implement that so we can force its use for public facing oauth clients.

Motivation and Context

Enhance current OAuth capabilities and work towards full adherence to the OAuth2.1 spec, in which feature such as PKCE are mandatory. Therefore giving the ability for Tyk users to stay at the most up to date security standards.

How This Has Been Tested

In your API definition you have a new field Oauth2Meta.RequirePKCE

When set to true for an oauth API any client generated for it will have no client secret and will be considered public. To authorise the client you must use a code challenge as described in https://tools.ietf.org/html/rfc7636

See the oauth tests for an example request.

All Oauth related unit tests passing with some minor changes. Additional test for new PKCE flow for public clients added.

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [x] Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

• [x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own fork, don't request your master!
• [x] Make sure you are making a pull request against the master branch (left side). Also, you should start your branch off our latest master.
• [ ] My change requires a change to the documentation.
  • [ ] If you've changed APIs, describe what needs to be updated in the documentation.
  • [ ] If new config option added, ensure that it can be set via ENV variable
• [ ] I have updated the documentation accordingly.
• [x] Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
• [x] When updating library version must provide reason/explanation for this update.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.
• [x] Check your code additions will not fail linting checks:
  • [x] go fmt -s
  • [x] go vet

[buger]

Looks like you need to update it from fresh master, and ensure that it use Go modues.

[buger]

Can you provide instructions for the QA team on how to test it?

[joshblakeley]

@buger how do i remove all the crap i've accidentally pulled in to the PR?

[joshblakeley]

This is a soft change. We now have optional PKCE under the hood. We will open another PR after this is merged to configure mandatory PKCE in oauth settings as it will require UI work and there is not much demand for it yet so can go in 3.4

[joshblakeley]

I broke this branch real good - might open a new one. Putting this in draft again for now

[joshblakeley]

Ok fixed and rebased on master

[joshblakeley]

@buger Now has full PKCE support added and new unit test for it too.

[joshblakeley]

Thanks for this. Next week - lt's do a zoom, as I'm not quite sure how this works.

Fantastic - pretty sure I have this at the point i can explain it all in a satisfactory way

[buger]

@joshblakeley @asoorm what was results of your call? Lets finally merge it.

[github-actions[bot]]

:boom: CI tests failed :see_no_evil:

CI test log

go: inconsistent vendoring in /home/runner/work/tyk/tyk:
	github.com/Jeffail/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Jeffail/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/alecthomas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/alecthomas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/bshuster-repo/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/buger/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cenk/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cenkalti/backoff/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/certifi/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/clbanning/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/codahale/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/dgrijalva/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/emanoelxavier/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/evalphobia/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/facebookgo/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/franela/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/franela/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gemnasium/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/getsentry/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-redis/redis/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gocraft/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/golang/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gorilla/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gorilla/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/hashicorp/consul/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/hashicorp/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/hashicorp/vault/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/huandu/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/imdario/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/jensneuse/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/jensneuse/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/justinas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/kelseyhightower/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/lonelycode/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mattn/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mavricknz/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mavricknz/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mgutz/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/miekg/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mitchellh/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/newrelic/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/nsf/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/opentracing/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/openzipkin/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/oschwald/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/paulbellamy/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pborman/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/peterbourgon/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pires/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pkg/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pmylund/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/robertkrimen/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/rs/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/satori/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/sirupsen/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/spf13/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/square/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/stretchr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/uber-go/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/uber/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/uber/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/valyala/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/x-cray/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xeipuuv/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xeipuuv/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xeipuuv/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xenolf/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/Masterminds/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/alecthomas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/square/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/vmihailenco/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	rsc.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/jensneuse/graphql-go-tools: is replaced in go.mod, but not marked as replaced in vendor/modules.txt

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory
go: inconsistent vendoring in /home/runner/work/tyk/tyk:
	github.com/Jeffail/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/Jeffail/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/TykTechnologies/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/alecthomas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/alecthomas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/bshuster-repo/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/buger/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cenk/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/cenkalti/backoff/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/certifi/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/clbanning/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/codahale/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/dgrijalva/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/emanoelxavier/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/evalphobia/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/facebookgo/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/franela/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/franela/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gemnasium/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/getsentry/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/go-redis/redis/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gocraft/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/golang/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/google/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gorilla/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/gorilla/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/hashicorp/consul/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/hashicorp/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/hashicorp/vault/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/huandu/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/imdario/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/jensneuse/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/jensneuse/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/justinas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/kelseyhightower/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/lonelycode/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mattn/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mavricknz/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mavricknz/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mgutz/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/miekg/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/mitchellh/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/newrelic/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/nsf/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/opentracing/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/openzipkin/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/oschwald/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/paulbellamy/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pborman/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/peterbourgon/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pires/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pkg/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/pmylund/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/robertkrimen/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/rs/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/satori/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/sirupsen/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/spf13/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/square/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/stretchr/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/uber-go/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/uber/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/uber/[email protected]+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/valyala/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/x-cray/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xeipuuv/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xeipuuv/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xeipuuv/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/xenolf/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	golang.org/x/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	google.golang.org/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/Masterminds/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/alecthomas/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/square/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/vmihailenco/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	gopkg.in/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	rsc.io/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/jensneuse/graphql-go-tools: is replaced in go.mod, but not marked as replaced in vendor/modules.txt

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory
building Go-plugin failed

gofmt

vendor/github.com/TykTechnologies/osin/urivalidate.go

goimports

vendor/github.com/TykTechnologies/osin/urivalidate.go

If the above are ok, please look at the run or in the Checks tab.

[joshblakeley]

This was "done" as of May but has fallen through the cracks. It needs a maintainer from one of the squads to take over if we are to get it tested and merged.