tyk icon indicating copy to clipboard operation
tyk copied to clipboard

[TT-1987 ] - Bad version number on go build

Open mcandre opened this issue 5 years ago • 1 comments

When you checkout a specific tag like v2.9.4 and run go build, the result reports --version as 2.10 instead.

Also, the Redis version-check-gateway key is missing at runtime when tyk is built from source with go build.

Please amend the build steps so that development versions report accurate version information.

For example, just print gateway.VERSION on --version.

Perhaps append a -dev suffix in master, if you like.

mcandre avatar Apr 22 '20 20:04 mcandre

The current automation sets the version appropriately and has been in effect since 4.0. The version can also be set via -X github.com/TykTechnologies/tyk/gateway.VERSION={{.Version}} on the command line while building by hand.

the Redis version-check-gateway key is missing at runtime when tyk is built from source with go build.

I'm not sure I understand the problem, would you explain it a bit more, or cite some documentation as to what is expected here?

alephnull avatar Apr 21 '22 15:04 alephnull

Hi,

I will close this issue, as it seems the issue no longer exists.

Please don't hesitate to open another ticket if the issue is still reproducible in latest Tyk.

Thanks for your contribution to Tyk!

andyo-tyk avatar Feb 27 '23 11:02 andyo-tyk