tyk-operator
tyk-operator copied to clipboard
TykTechnologies
[TT-4615] environmet.Env.Parse doesnt return errors on bad data
⚠️ ⚠️ ⚠️ environmet.Env.Parse is documented as returning errors on failure to validate. In reality, it doesn't return an error and callers have to further validate by themselves see 1, 2
⚠️ ⚠️ ⚠️
Expected Behavior
environmet.Env.Parse docs should remove phrases insinuating that it returns errors on validation.
Additional Context
Current behaviour will remain unchanged. At some point in the past, it did return errors, see
@oneEyedSunday thank you for raising this issue! We will check for potential fixes for it. Let's keep this issue open until then. Again, thanks!
It seems there is typo in the package name environmet which should probably be environment.
Well at this point that's basically a feature. It's ingrained into the whole application
On Tue, 1 Mar 2022, 22:27 touk, @.***> wrote:
It seems there is typo in the package name environmet which should probably be environment.
— Reply to this email directly, view it on GitHub https://github.com/TykTechnologies/tyk-operator/issues/392#issuecomment-1055876725, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDNOO4BI3CAZNT5RIRRVZLU52DT5ANCNFSM5N4QW6XA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Thank you for raising this issue to us. The fix will be available in release 0.15.1
