tyk-gateway-docker icon indicating copy to clipboard operation
tyk-gateway-docker copied to clipboard

It's not clear which Dockerfile the automated build is based on

Open marians opened this issue 7 years ago • 5 comments

When checking

https://hub.docker.com/r/tykio/tyk-gateway/~/dockerfile/

on the right hand side the Github repo link is

https://github.com/lonelycode/tyk-gateway-docker

Following that link however redirects to this repo here

https://github.com/TykTechnologies/tyk-gateway-docker

The Dockerfile in here (https://github.com/TykTechnologies/tyk-gateway-docker/blob/master/Dockerfile) is not the same as is shown on https://hub.docker.com/r/tykio/tyk-gateway/~/dockerfile/ .

I hope the problem is clear.

marians avatar Jul 24 '17 12:07 marians

This is because the docker repos use branches: https://github.com/TykTechnologies/tyk-gateway-docker/branches

I know, it's confusing and unnecessarily verbose, but that's how all of our docker repos are set up :) I got stuck with the same when I first saw this repo.

mvdan avatar Jul 24 '17 12:07 mvdan

Thanks for the info! Maybe a README would help? Also, the link at Dockerhub could point to the actual repository.

marians avatar Jul 24 '17 12:07 marians

Thanks for the pointer regarding the links - I'll file an internal ticket to make sure they're all updated.

mvdan avatar Jul 24 '17 12:07 mvdan

Regarding the repo setup, we'll try to swap the structure to master with tags soon(tm). That shouldn't need any README changes, as it would be fairly obvious - and what you tried to do initially.

mvdan avatar Jul 24 '17 12:07 mvdan

I highly recommend that. This Dockerfile in master, being based on dockerfile/ubuntu doesn't look so good. ;-)

marians avatar Jul 24 '17 12:07 marians