graphql-go-tools icon indicating copy to clipboard operation
graphql-go-tools copied to clipboard

[POC][TT-11212]kin-openapi-upgrade

Open jeffy-mathew opened this issue 1 year ago • 4 comments

related issue https://tyktech.atlassian.net/browse/TT-11212

jeffy-mathew avatar Feb 06 '24 08:02 jeffy-mathew

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 06 '24 08:02 sonarqubecloud[bot]

Hey @jeffy-mathew, thank you for opening this PR. I tried to upgrade the OpenAPI parser on my local. It seems that we can upgrade it to the latest with little effort but one of the integration tests is broken. If you can give more information about how it is urgent for your team, we can make some arrangements on our side.

buraksezer avatar Feb 08 '24 13:02 buraksezer

@buraksezer thanks for your interest and sorry for the late reply. We're looking into identifying the impact of upgrading the openapi library(had to deprioritize it after our last cooldown). With this PR and related PRs in gateway and dashboard we found it's a relatively easy upgrade. Right now I'm analysing what are the potential impacts of upgrading from different versions. ~~Once that's assessed and if there aren't any blockers, we will be able to fast track this. In the mean time, could you help us with the integration tests you've mentioned?~~ However I can see that kin-openapi isn't a dependancy in this repo anymore. So I assume it's safe to close this PR

jeffy-mathew avatar Apr 17 '24 12:04 jeffy-mathew