quick_count icon indicating copy to clipboard operation
quick_count copied to clipboard

Published 20 hours ago • verified publisher icon TwilightCoders

Add rails 6.0 support

Open zoommix opened this issue 4 years ago • 5 comments

@voltechs @Benjaminpjacobs

zoommix avatar Nov 01 '20 18:11 zoommix

Hi @zoommix, thanks for the PR! This won't pass specs without the corresponding gemfiles/activerecord-6.0.Gemfile file as well.

voltechs avatar Dec 09 '20 20:12 voltechs

Hi @voltechs. My bad, thanks for the catch! The pr is updated.

zoommix avatar Dec 26 '20 18:12 zoommix

:+1: for the merge!

MauricioMoraes avatar Feb 21 '21 14:02 MauricioMoraes

Obs: The "pry" gem is required for this PR to work. It should be declared in the dependencies

MauricioMoraes avatar Feb 21 '21 14:02 MauricioMoraes

Obs: The "pry" gem is required for this PR to work. It should be declared in the dependencies

@MauricioMoraes Isn't dependency declared in quick_count.gemspec enough? We only need it on development so no need to add pry to activerecord-6.0.Gemfile. bundle install successfully installed pry on my local machine. Please correct me if I'm wrong.

zoommix avatar Mar 01 '21 14:03 zoommix