Maximum storage limits are too low

[bobobo1618]

In Settings -> Storage, the maximum selectable value for "Database size limit" is 500 items. The maximum selectable value for "cache size limit" is 500MB.

I follow a lot of users in a different timezone to mine and this means that overnight while I sleep, ~1000 items will accumulate that I'd like to catch up on through my day. At the moment, it seems to me that Twidere will simply lose these items.

I've built myself an APK with these maximums drastically increased (10000 items in the database and 10GB of cache) and I'll be testing to see how they hold up.

I saw https://github.com/TwidereProject/Twidere-Android/pull/15 was closed without comment but if I send another CL that looks mostly the same, will it also be rejected? If so, why?

[mariotaku]

@bobobo1618 If we load too many tweet from database, app my crash due to CursorWindow limit (2MB normally). One row may contain ~3KB data, if we load 1500 it would be ~4.5MB, way beyond 2MB limit.

[bobobo1618]

Ah, I see, thanks for the explanation. I tested with 1300 items overnight but I suppose my items might be smaller than other people's and it might work for me but not them.

I'll have a look and see if I can finagle some kind of lazy loading mechanism into the app so you don't need to load the entire database at once.

[mariotaku]

@bobobo1618 Paging is what we need. I'll use this for data loading and make storage limit way higher.

[yoshimo]

@mariotaku is that something we can get improved for devices with more storage before twidereX takes over? Having an unlimited option would help massively with larger subscrition lists