TwiN
TwiN
Thank you for the contribution!
Hey, just so you know, I'm currently working on #929, which _may_ also implement what this PR is implementing.
Hey, sorry about this, I'm going to close this because I've been working on adding support for provider overrides at the alert level, and this impacts how overrides in general...
@0n1cOn3 oh crap, you're completely right. I went through the files changes way too quickly, saw green and overrides & assumed it was the change 🤦♂️
@medaved Some tests are failing ``` # github.com/TwiN/gatus/v5/alerting/provider/telegram [github.com/TwiN/gatus/v5/alerting/provider/telegram.test] Error: alerting/provider/telegram/telegram_test.go:159:32: unknown field ID in struct literal of type AlertProvider Error: alerting/provider/telegram/telegram_test.go:159:43: unknown field TopicId in struct literal of type...
@sw5ciprl I left a comment at https://github.com/TwiN/gatus/pull/928#discussion_r2001846502 Once @medaved has addressed the comment, I'll re-review
@sw5ciprl Thank you, usually I wait until I test the changes myself, but having a 3rd party confirm it works as intended is a great replacement. Appreciate the feedback :)
@medaved Thank you for the contribution!
Looks like there's a build error
Looks like one of the test is failing 😔