psn-php icon indicating copy to clipboard operation
psn-php copied to clipboard

PHP 8.1 Deprecated Messages

Open Ragowit opened this issue 2 years ago • 5 comments

[11-Jan-2022 22:01:03 UTC] PHP Deprecated:  Return type of Tustin\PlayStation\Iterator\AbstractApiIterator::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/psn100/public_html/vendor/tustin/psn-php/src/Iterator/AbstractApiIterator.php on line 63
[11-Jan-2022 22:01:03 UTC] PHP Deprecated:  Return type of Tustin\PlayStation\Iterator\AbstractApiIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/psn100/public_html/vendor/tustin/psn-php/src/Iterator/AbstractApiIterator.php on line 114
[11-Jan-2022 22:01:03 UTC] PHP Deprecated:  Return type of Tustin\PlayStation\Iterator\UsersSearchIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/psn100/public_html/vendor/tustin/psn-php/src/Iterator/UsersSearchIterator.php on line 79
[11-Jan-2022 22:01:58 UTC] PHP Deprecated:  Return type of Tustin\PlayStation\Iterator\TrophyTitlesIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/psn100/public_html/vendor/tustin/psn-php/src/Iterator/TrophyTitlesIterator.php on line 39
[11-Jan-2022 22:03:10 UTC] PHP Deprecated:  Return type of Tustin\PlayStation\Iterator\TrophyGroupsIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/psn100/public_html/vendor/tustin/psn-php/src/Iterator/TrophyGroupsIterator.php on line 50
[11-Jan-2022 22:03:11 UTC] PHP Deprecated:  Return type of Tustin\PlayStation\Iterator\TrophyIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/psn100/public_html/vendor/tustin/psn-php/src/Iterator/TrophyIterator.php on line 51

Ragowit avatar Jan 12 '22 19:01 Ragowit

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 03:04 stale[bot]

Still a thing.

Ragowit avatar Apr 16 '22 06:04 Ragowit

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 19 '22 08:06 stale[bot]

Still an issue.

Ragowit avatar Jun 20 '22 07:06 Ragowit

Still an issue.

impshum avatar Aug 02 '22 12:08 impshum

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 16 '22 04:10 stale[bot]

Still an issue.

PHP 8.0 will reach end of active support in 1 month. PHP 8.2 will be released at that time.

Ragowit avatar Oct 16 '22 20:10 Ragowit

@Ragowit Sorry for taking so long on this. I've added the #[\ReturnTypeWillChange] attribute to each of the functions you mentioned which should hopefully remove those errors. Eventually I'll get rid of this attribute in favor of the mixed return type where applicable, but only once we drop PHP 7.4 support. Please check the php81-deprecation branch to see if it resolves the issue 👍

Tustin avatar Oct 18 '22 19:10 Tustin

Thanks! PHP 7.4 will reach end of all support on 28 Nov 2022, so you could probably drop support for it quite soon.

Ragowit avatar Oct 18 '22 19:10 Ragowit

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 07 '23 17:01 stale[bot]

This is fixed in the 4.0 release, thanks!

Ragowit avatar Jan 07 '23 17:01 Ragowit