Jude Melton-Houghton

Results 137 comments of Jude Melton-Houghton
trafficstars

Perhaps the past attempt was rejected because it exposed the FFI objects directly (which is insecure.)

Question: How lax must we be in accepting input? The old implementation of `set_data` will read non-number elements of the given array as 0. Must this behavior be preserved?

@Desour Thanks for the tips. I'll definitely look at your work on this. If someone sets a hook that interrupts someone else's code, I wouldn't consider that legitimate. The setter...

Here's a temporary benchmark patch to test the bulk accessor functions. On my computer, the FFI versions are over twice as fast. ```patch diff --git a/games/devtest/mods/experimental/commands.lua b/games/devtest/mods/experimental/commands.lua index e42ae954d..79f2b8b1f 100644...

I can't get the APK working. Could someone run the APK and see if it works? I don't know if the symbols will be accessible to the ffi library.

I will provide some reasoning behind considering `get_data` etc. to be secure: These functions all obtain the `m_data` pointer and area volume of the underlying `VoxelManipulator`. However, Lua functions can...

@Desour * I'll leave changes to specific functions to be done in #12438 and similar PRs. * Perhaps I can try this, but it may not have a lot of...

Won't this break a ton of mods that use `get_wielded_item` and `set_wielded_item` in `on_use` callbacks etc.? Perhaps `{get,set}_wielded_item` could vary which inventory it modifies depending on context (i.e. where the...

Closing since equivalent functionality is being implemented in https://github.com/minetest/minetest/pull/12438.

I'll reopen this as it seems the other PR isn't very active anyway.