feedback-editor icon indicating copy to clipboard operation
feedback-editor copied to clipboard

Does not recompile

Open whamer100 opened this issue 9 years ago • 17 comments

Hello TurkeyMan, I've been a follower of FeedBack ever since 2011 or so, and I've recently tried modifying the source to this program to try and add support for hopo flip notes (N 5 0) and tap notes (N 6 0), and I dont know whats wrong, but I cannot get it to compile. I'd like some help here.

Thanks in advance, -whamer100

whamer100 avatar Feb 26 '16 02:02 whamer100

Hey that's cool. Yeah this is just a dump of the state of it from wherever it was at last time I touched it. I'll have a go at getting it building with recent build tools. Been meaning to do it for a while, just never had a reason to make the time.

TurkeyMan avatar Feb 26 '16 04:02 TurkeyMan

Out of curiosity, what problems are you running into?

TurkeyMan avatar Feb 26 '16 04:02 TurkeyMan

I actually only get one error, but I don't know much D so I just get stuck trying to fix it, I'll go look for the error if you want me to

whamer100 avatar Feb 26 '16 04:02 whamer100

Wait up... you're building D code? Are you building Feedback??

You posted the issue here, which is where my old (ancient) editor lives, and there's no D in here. If you're building D code, you must be trying to build the new Feedback, which is still work-in-progress...?

TurkeyMan avatar Feb 26 '16 07:02 TurkeyMan

If you can tell me the error, that might be helpful, but it sounds like you might be building the wrong project? What is it that you actually want to do?

TurkeyMan avatar Feb 26 '16 07:02 TurkeyMan

I was trying to compile the wrong FeedBack, but I want to get the old FeedBack to compile, but it shows that it's missing some projects. One called Fuji_PC.vcproj, and libmad.vcproj. I cannot find the Fuji project file it wants, nor libmad.vcproj

whamer100 avatar Feb 26 '16 15:02 whamer100

It expects to find Fuji parallel. I'm about to push my updates from yesterday to make it a submodule and with build fixes, so gimme a bit and you shouldn't need to worry about it...

TurkeyMan avatar Feb 27 '16 00:02 TurkeyMan

Alright :D

whamer100 avatar Feb 27 '16 00:02 whamer100

Hello, its me again, I was wondering if you can make a tutorial for me so I can get the program to compile. It doesn't seem to be able to find Fuji or even the FeedBack solution files.

whamer100 avatar Apr 09 '16 04:04 whamer100

I made it compile the other day, but it doesn't seem to read the keyboard now, and has some rendering problem which I haven't fixed (doesn't render some text), so I need to do a bit more work, but it does technically build and run now ;) It's probably easiest if you just clone a fresh copy, make sure to use --recursive when you clone (ie, fetch submodules recursively). Then go into the FeedBack/Project/ folder, run create_project.bat. I've only tested using VS2015, so if you use that, you'll probably have better luck. It will create FeedBack.sln in the Project folder, which you can open in Visual Studio. Let me know if that works for you?

TurkeyMan avatar Apr 11 '16 08:04 TurkeyMan

Oh yeah, you also need to set the proper working directory when you run, which should be the FeedBack/ directory. I think it defaults to $(ProjectDir), which is the FeedBack/Project/ subdir where it generated the project. You can change it in VS by; right click FeedBack project -> Properties -> Debugging -> Working Directory I just use $(ProjectDir)..

TurkeyMan avatar Apr 11 '16 08:04 TurkeyMan

it gives me this error when I try to run it: http://prntscr.com/as01vj

whamer100 avatar Apr 14 '16 03:04 whamer100

Another thing, is that when I actually build it rather than debug it, it looks like this: http://prntscr.com/as02r1

whamer100 avatar Apr 14 '16 03:04 whamer100

And then when I close the program, this happens: http://prntscr.com/as02v0

whamer100 avatar Apr 14 '16 03:04 whamer100

it gives me this error when I try to run it: http://prntscr.com/as01vj

That is a result of incorrect working directory

Another thing, is that when I actually build it rather than debug it, it looks like this: http://prntscr.com/as02r1

That's the bit where I said "it doesn't render some text". I'm sure it's a trivial fix, I just gotta find it ;)

The bigger problem though is that it doesn't read the keyboard correctly...

And then when I close the program, this happens: http://prntscr.com/as02v0

Looks like a new shutdown bug.

Bear in mind, I had to do a lot of work to get this ancient code (when was the last actual release? 2007 maybe?) running against the latest version of Fuji. There are certainly some new issues that crept in in the process, I just need to find some more time to work through them, or you're welcome to hack at it too if you like. The memory corruption shutdown bug might not be hard to find, and that might fix some other bug in the process too.

TurkeyMan avatar Apr 14 '16 04:04 TurkeyMan

Alright, thanks for explaining those, I was wondering what those meant. If you fix the bugs, let me know so I can get back to my modding :D

whamer100 avatar Apr 14 '16 23:04 whamer100

Are you proud of Jacob Landon? https://www.youtube.com/watch?v=9QDVC_1Thvg

Welldoneshellfish avatar May 05 '17 21:05 Welldoneshellfish