node-s3-uploader icon indicating copy to clipboard operation
node-s3-uploader copied to clipboard

Buffer / url as source

Open PierrickP opened this issue 9 years ago • 3 comments

I would like to pass a buffer or url to upload()

aws.putObject accept buffer / string / stream http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#putObject-property

Maybe you can change https://github.com/Turistforeningen/node-s3-uploader/blob/master/index.js#L95 to accepte original things passed to src like buffer or stream (with backward compatibility if its a path)

Thanks

PierrickP avatar Jul 07 '16 08:07 PierrickP

Hi @PierrickP and thank you for your suggestion! This is something we too would like to have support for, however the tricky part is to pass steams to ImageMagick for processing before they are uploaded 😕

Starefossen avatar Jul 07 '16 08:07 Starefossen

indeed ! I ll check that

PierrickP avatar Jul 07 '16 08:07 PierrickP

Great! 😄 Pull requests are always welcome 🚀

You can check out im-metadata and im-resize which wraps the ImageMagick command line.

Starefossen avatar Jul 07 '16 09:07 Starefossen