leaflet-routing icon indicating copy to clipboard operation
leaflet-routing copied to clipboard

Support Leaflet 1.0

Open nrenner opened this issue 8 years ago • 5 comments

Suggesting to support Leaflet 1.0 by updating to current version 1.0.3 and fixing any breaking changes.

Obvious breaking changes so far (see also Changelog 1.0-beta1):

  • [x] clickable > interactive
    • Renamed clickable option to interactive (by AndriiHeonia). #2838 #2499
  • [x] L.Routing.Storage extends removed L.MultiPolyline
    • Removed MultiPolyline and MultiPolygon classes since multiple rings are now handled by Polyline and Polygon classes respectively. Layers with multiple rings now perform much better (since each is now physically a single path object instead of being a FeatureGroup of layers).

Not sure what to do with L.Routing.Storage: extend Polyline or FeatureGroup or copy over old MultiPoly implementation? It doesn't seem to be used anywhere and is not documented in the Readme, could we even remove this L.Routing.Storage class?

nrenner avatar Jan 30 '17 11:01 nrenner

@Starefossen What about the Storage class (see comments above)? I would tend to delete it?

nrenner avatar Feb 11 '17 08:02 nrenner

I decided to delete the Storage class as it would be a breaking change anyway and it doesn't seem to be used anywhere.

Created a separate issue #45 for MultiPolyline and MultiPolygon in LineUtil.Snapping.js, won't address this as we're not using snapping yet and is seems to work fine with just LineStrings.

Ready for review and merging now.

nrenner avatar Jun 03 '17 14:06 nrenner

Sorry for the lack of effort by my part. It looks like a solid effort has been made into this, @nrenner!

I would very much like you to take over as lead maintainer for this project with the merge of this PR if you would like that 🙂

Starefossen avatar Jun 03 '17 16:06 Starefossen

Thanks for your trust. Not sure what to say, I would rather want to reduce the number of projects to maintain.

But am I right to assume that you're no longer with Turistforeningen and that leaflet-routing is not actually being used in production there? Then it might make sense as long as we're still using it with brouter-web.

nrenner avatar Jun 17 '17 15:06 nrenner

@nrenner any news on that?

bagage avatar Oct 07 '19 20:10 bagage