MCMCChains.jl icon indicating copy to clipboard operation
MCMCChains.jl copied to clipboard

Make Chains objects display only information and not statistical eval

Open PaulinaMartin96 opened this issue 4 years ago • 5 comments

As suggested on #246, Chains objects now display only information and not statistical evaluations.

Before: MCMCChainsnotmodified

After: MCMCChainsmodified

Also, the describe function now display both Summary statistics and Quantiles info.

Before: describenotmodified

After: describemodified

PaulinaMartin96 avatar Jun 10 '21 04:06 PaulinaMartin96

Woops, I missed this one as reviewable. If I forget, as I do often, you can flag me by requesting a review over here:

image

cpfiffer avatar Jul 06 '21 19:07 cpfiffer

@cpfiffer thank you so much for the suggestions! I'll consider them in the future. I think the PR is ready. There's a conflict with Project.toml. Let me know if further changes are required.

PaulinaMartin96 avatar Jul 07 '21 05:07 PaulinaMartin96

Okay, thanks for adding that stuff. Looks good to me.

When there's a merge conflict, it's typically the PR person's job to fix the merge conflict. Fortunately this one is really easy -- you can use the GitHub web editor or your local git merge manager to fix the issues. GitHub has links on how to do this at the bottom of the PR scroll:

image

This is a good learning opportunity since it's one of the easier merge conflicts. Go ahead and try to fix this issue. In this case, you basically want to fix the version number to the one you specified (4.14.0) and not the one that's currently in master.

cpfiffer avatar Jul 07 '21 15:07 cpfiffer

Sorry for that, and again, thank you so much for your advice!

PaulinaMartin96 avatar Jul 07 '21 18:07 PaulinaMartin96

No problem, all part of the learning process. I've just enabled tests and will check back to make sure they've passed.

cpfiffer avatar Jul 07 '21 19:07 cpfiffer