Bijectors.jl icon indicating copy to clipboard operation
Bijectors.jl copied to clipboard

Skellam (special case) is broken with Zygote and SpecialFunctions >= 1

Open devmotion opened this issue 5 years ago • 7 comments

Currently, these distributions are broken due to https://github.com/FluxML/Zygote.jl/issues/873. As discussed in https://github.com/TuringLang/Bijectors.jl/pull/155, the corresponding tests are marked as broken. The issue will be fixed upstream.

See also: https://github.com/TuringLang/DistributionsAD.jl/issues/145

devmotion avatar Jan 07 '21 00:01 devmotion

Copy from https://github.com/TuringLang/DistributionsAD.jl/issues/145#issuecomment-853794894:

The main issue was fixed upstream, only some interesting issue due to Zygote._zero with ChainRulesCore.NotImplemented for matrices of Skellam variates is left: https://github.com/TuringLang/DistributionsAD.jl/pull/172

devmotion avatar Jun 03 '21 23:06 devmotion

So I guess this can be closed?

torfjelde avatar Jun 05 '21 09:06 torfjelde

No, Skellam is still broken with Zygote in one test.

devmotion avatar Jun 05 '21 09:06 devmotion

Do you know which one? I just had to remove a bunch of broken = (:zygote, ) to make tests pass in #177 so jus curious which one still remains.

torfjelde avatar Jun 05 '21 10:06 torfjelde

Are you sure? I fixed these in https://github.com/TuringLang/Bijectors.jl/pull/182, I thought.

devmotion avatar Jun 05 '21 10:06 devmotion

Ah, it seems you updated the tests before merging the master branch. I updated this issue here when I fixed the tests in https://github.com/TuringLang/Bijectors.jl/pull/182, so the remaining error is still not fixed.

devmotion avatar Jun 05 '21 10:06 devmotion

Aaaah, my bad; thanks!

torfjelde avatar Jun 05 '21 11:06 torfjelde