AdvancedHMC.jl icon indicating copy to clipboard operation
AdvancedHMC.jl copied to clipboard

Make ∂H∂r consistent with ∂H∂θ

Open ErikQQY opened this issue 8 months ago • 4 comments

Fix: #173

While ∂H∂θ return a DualValue containing log density and its gradient, this PR makes ∂H∂r consistent with ∂H∂θ and return a DualValue containing negative energy and momentum.

This PR also change the weird argumnet order of neg_energy(h, r, θ) to neg_energy(h, θ, r), which is more commonly used in this package, e.g. phasepoint(h, θ, r),

ErikQQY avatar Jun 25 '25 06:06 ErikQQY

AdvancedHMC.jl documentation for PR #458 is available at: https://TuringLang.github.io/AdvancedHMC.jl/previews/PR458/

github-actions[bot] avatar Jun 25 '25 06:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.42%. Comparing base (5a562e0) to head (41c04ab).

Files with missing lines Patch % Lines
src/riemannian/hamiltonian.jl 0.00% 3 Missing :warning:
src/riemannian/integrator.jl 0.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   75.44%   75.42%   -0.03%     
==========================================
  Files          21       21              
  Lines        1230     1233       +3     
==========================================
+ Hits          928      930       +2     
- Misses        302      303       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 26 '25 12:06 codecov[bot]

HISTORY is updated and a minor version is bumped!

ErikQQY avatar Jun 28 '25 14:06 ErikQQY

This is mainly reshuffling some internal logic, isn't it?

nsiccha avatar Nov 21 '25 10:11 nsiccha