AdvancedHMC.jl icon indicating copy to clipboard operation
AdvancedHMC.jl copied to clipboard

Fix Step

Open JaimeRZP opened this issue 2 years ago • 2 comments

Fix #350

JaimeRZP avatar Nov 03 '23 09:11 JaimeRZP

This will fix the error I ran into, but the more general problem still exists: Since AdvancedHMC adds special keyword arguments to sample, sample and the step and steps iterators/transducers become inconsistent and generic calls of sample in other packages will perform sampling differently from AdvancedHMC because in general n_adapts etc. are not supported by sample and hence can't be provided in such generic situations.

That is, I think to fix these inconsistencies customizations of the sample call should mainly be done via the sampler (e.g., by adding fields that change the behaviour of step).

devmotion avatar Nov 07 '23 12:11 devmotion

I suggest merging this PR for a hotfix; we can remove n_adapts when https://github.com/TuringLang/AbstractMCMC.jl/pull/117 is complete.

yebai avatar Nov 07 '23 21:11 yebai