AdvancedHMC.jl icon indicating copy to clipboard operation
AdvancedHMC.jl copied to clipboard
verified publisher icon TuringLang

Struct naming improvments

Open xukai92 opened this issue 4 years ago • 1 comments

  • FixedNSteps -> FixedIntegrationSteps (https://github.com/TuringLang/AdvancedHMC.jl/pull/245#discussion_r575863482)
  • Make no-U-turns struct less verbose
    • NoUTurn -> ClassicNoUTurn
    • GeneralisedNoUTurn -> NoUTurn
    • StrictGeneralisedNoUTurn -> StrictNoUTurn

xukai92 avatar Feb 15 '21 00:02 xukai92

Make no-U-turns struct less verbose

Maybe introduce a few type alias instead of changing these (internal) type names? Overall, I'm leaning towards using descriptive variable/function names since it makes code more readable.

yebai avatar Feb 15 '21 15:02 yebai