turf icon indicating copy to clipboard operation
turf copied to clipboard

Fix Issue #1232 - Bug in turf-line-split

Open hanneshdc opened this issue 2 years ago • 1 comments

This PR fixes #1232.

The cause of the issue is the application of turf-square to feature bounding boxes, which sometimes incorrectly results in a smaller bounding box. While this is really a bug in turf-square, the application isn't needed here. Instead, we can remove the bbox calculation completely and allow geojson-rbush to calculate it for us instead.

From the template:

  • [ x ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ x ] Have read How To Contribute.
  • [ x ] Run npm test at the sub modules where changes have occurred.
  • [ x ] Run npm run lint to ensure code style at the turf module level.

Submitting a new TurfJS Module. (N/A)

hanneshdc avatar Jul 21 '23 14:07 hanneshdc

I'd like to merge this. Any chance you have time to clean up the merge conflicts first?

mfedderly avatar Aug 05 '24 17:08 mfedderly

Hi, what's the reason for closing this PR? Was is solved in another PR?

kudlav avatar Nov 21 '24 13:11 kudlav

@kudlav not sure what happened! GitHub seems to have automatically closed it when I rebased the branch.

Have re-opened.

hanneshdc avatar Nov 24 '24 02:11 hanneshdc

Thanks for doing this @hanneshdc. Sorry it took so long to merge.

smallsaucepan avatar May 25 '25 03:05 smallsaucepan