scratch-gui
scratch-gui copied to clipboard
TurboWarp
Support the dark mode from SA as a separate thing from our own dark mode, maybe
At least add the TW dark mode as a preset to sa, it's very highly requested
Sent via the Samsung Galaxy A52 5G, an AT&T 5G smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: GarboMuffin @.> Sent: Wednesday, July 21, 2021 7:35:07 PM To: TurboWarp/scratch-gui @.> Cc: Subscribed @.***> Subject: [TurboWarp/scratch-gui] Throw away our dark mode and just use the one from SA (#284)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/TurboWarp/scratch-gui/issues/284, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOT5DEQRKO3UDKF3ENM6UBTTY5RTXANCNFSM5AY7VPUA.
My enthusiasm to do this has decreased massively now that I've learned that the SA dark mode has a nearly 1000 line JSON file doings things that, in my opinion, don't belong in addon.json.
There's also a lot of non-insignificant style differences even with the same colors configured in the addon.
There's also a lot of hardcoded classes with hashes, many of which will certainly not match.
This won't be happening soon. (but maybe eventually)
My enthusiasm to do this has decreased massively now that I've learned that the SA dark mode has a nearly 1000 line JSON file doings things that, in my opinion, don't belong in addon.json.
Do you have any suggestions for a better implementation? The colors need to be available to the CSS as soon as possible, so a userscript is not appropriate.
There's also a lot of non-insignificant style differences even with the same colors configured in the addon.
I don't think that can be avoided because SA's dark mode allows colors to be customized individually, and adding a separate setting for every element would make the addon very hard to use.
There's also a lot of hardcoded classes with hashes, many of which will certainly not match.
(I don't think any of them will match in TW Desktop)
That should be fixed in SA.
I think I was a bit upset from something else when I wrote that. customCSSVariables will be easier to implement than I initially thought, and my other excuse I told myself at the time (bundle size) doesn't make sense either.
Most of the style differences ended up looking better but some of them looked worse, I'll look into making a list of everything major. May end up making a few changes myself for those.
There have been some developments since the time this was opened
- customCssVariables has been implemented. I don't know why I was so opposed to this.
- We have a way to put addons in a more hidden place ("dangerous")
- https://github.com/ScratchAddons/ScratchAddons/pull/5595
I think we will have Scratch Addons' dark mode as a separate addon, initially hidden somewhere obscure