extensions icon indicating copy to clipboard operation
extensions copied to clipboard

add extension: ShareSheet

Open CreeperNewGamer opened this issue 2 months ago • 34 comments

CreeperNewGamer avatar Oct 05 '25 08:10 CreeperNewGamer

Your image should be SVG + you need to add your extension to extensions.json (personally I would put it after close controls because both interface with the browser UI) Also this isn't supported on Firefox desktop yet.

8to16 avatar Oct 05 '25 15:10 8to16

Ok let me do this maybe later

CreeperNewGamer avatar Oct 05 '25 17:10 CreeperNewGamer

!format

PPPDUD avatar Oct 16 '25 18:10 PPPDUD

!format

Brackets-Coder avatar Oct 16 '25 18:10 Brackets-Coder

@CreeperNewGamer the previous commit should fix some of your issues

In the future, always try to use Scratch.Cast and Scratch.translate where applicable.

If you want this extension to appear in the gallery, you'll need to add the relevant information to extensions.json. You can view how in the contributing guidelines.

Brackets-Coder avatar Oct 16 '25 18:10 Brackets-Coder

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

github-actions[bot] avatar Oct 16 '25 18:10 github-actions[bot]

Oh thanks, is this helping me so much! YAY!

CreeperNewGamer avatar Oct 16 '25 18:10 CreeperNewGamer

Also can you please appear this extension on the gallery, and you also help me creating a better thumbnail!

CreeperNewGamer avatar Oct 16 '25 18:10 CreeperNewGamer

Also can you please appear this extension on the gallery, and you also help me creating a better thumbnail!

I'll see what I can do, but I'm not good at graphic design.

Brackets-Coder avatar Oct 16 '25 19:10 Brackets-Coder

I added the line to extensions.json, so your extension should appear somewhere around the middle of the gallery if this gets merged.

Brackets-Coder avatar Oct 16 '25 19:10 Brackets-Coder

Can 2 peoples review this, because of this: image

CreeperNewGamer avatar Oct 16 '25 20:10 CreeperNewGamer

Your code had a bug causing the <is share sheet supported?> block to hang forever, so I fixed it for you.

PPPDUD avatar Oct 16 '25 20:10 PPPDUD

Your code had a bug causing the <is share sheet supported?> block to hang forever, so I fixed it for you.

Thanks

CreeperNewGamer avatar Oct 16 '25 20:10 CreeperNewGamer

Your code had a bug causing the <is share sheet supported?> block to hang forever, so I fixed it for you.

Thanks

Happy to help!

PPPDUD avatar Oct 16 '25 20:10 PPPDUD

ShareSheet is not supported on Chromium with Ubuntu 25.04; what platforms is it supposed to work on?

PPPDUD avatar Oct 16 '25 20:10 PPPDUD

ShareSheet is not supported on Chromium with Ubuntu 25.04; what platforms is it supposed to work on?

This also does not work. Tested on Arch Linux, Chromium 141.0.7390.76.

8to16 avatar Oct 16 '25 20:10 8to16

But is working on iPad 7th running iPadOS 18.7, for me

CreeperNewGamer avatar Oct 17 '25 04:10 CreeperNewGamer

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

CreeperNewGamer avatar Oct 17 '25 04:10 CreeperNewGamer

Sorry I’m late, I was sleeping before

CreeperNewGamer avatar Oct 17 '25 04:10 CreeperNewGamer

Ah yes!

https://github.com/user-attachments/assets/59c0854a-4f88-47ad-a346-cbd199875a51

CreeperNewGamer avatar Oct 17 '25 04:10 CreeperNewGamer

If you now wondering with my thumbnail then you are in luck, because I updated it to svg and a better look

CreeperNewGamer avatar Oct 17 '25 05:10 CreeperNewGamer

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

What about Windows 10? Windows 8.1? macOS? You need a platform support sheet of some sort.

PPPDUD avatar Oct 17 '25 13:10 PPPDUD

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

What about Windows 10? Windows 8.1? macOS? You need a platform support sheet of some sort.

is too hard to answer, sorry.

CreeperNewGamer avatar Oct 17 '25 13:10 CreeperNewGamer

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

What about Windows 10? Windows 8.1? macOS? You need a platform support sheet of some sort.

is too hard to answer, sorry.

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share#browser_compatibility

CreeperNewGamer avatar Oct 17 '25 13:10 CreeperNewGamer

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

What about Windows 10? Windows 8.1? macOS? You need a platform support sheet of some sort.

is too hard to answer, sorry.

Until I get further compatibility information, I will withhold my approval. You need 2 approvals to be accepted, it's school year for most people, and there's only 8 people with the authority to issue an approval (I am one of them).

PPPDUD avatar Oct 17 '25 13:10 PPPDUD

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

What about Windows 10? Windows 8.1? macOS? You need a platform support sheet of some sort.

is too hard to answer, sorry.

Until I get further compatibility information, I will withhold my approval. You need 2 approvals to be accepted, it's school year for most people, and there's only 8 people with the authority to issue an approval (I am one of them).

image

CreeperNewGamer avatar Oct 17 '25 13:10 CreeperNewGamer

This seems to be working for me on Safari Desktop I haven't tried Firefox yet—MDN says it's not supported, but if you click on it, it says you have to enable a feature flag

@CreeperNewGamer However, I was not able to get the "set data to costume" block to work, the costume data was blank. It seems to only work with bitmap images.

Brackets-Coder avatar Oct 17 '25 13:10 Brackets-Coder

To answer this question "what platforms is it supposed to work on" is mobile or windows 11

What about Windows 10? Windows 8.1? macOS? You need a platform support sheet of some sort.

is too hard to answer, sorry.

Until I get further compatibility information, I will withhold my approval. You need 2 approvals to be accepted, it's school year for most people, and there's only 8 people with the authority to issue an approval (I am one of them).

image

Okay, you've got me. I'm still a bit iffy about things, but I'll leave @Brackets-Coder to handle this instead.

PPPDUD avatar Oct 17 '25 13:10 PPPDUD

Also, may I inquire as to why you're developing on an iPad? (it won't make your extension less favorable if it still works and passes all the checks, but it does make it harder to develop)

Brackets-Coder avatar Oct 17 '25 13:10 Brackets-Coder

I'm having issues to accept this, but when I figure it out then I accept it!

CreeperNewGamer avatar Oct 17 '25 13:10 CreeperNewGamer