extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Documentation Alerts bug fixing

Open Brackets-Coder opened this issue 8 months ago • 12 comments

Let's try this again.

This makes documentation alerts case-insensitive.

This is the easiest solution and is better than requiring all caps, as the latter breaks the alert's title and formatting.

Putting HTML into block alerts has extra padding due to empty auto-generated <p> elements, planning on fixing whenever I can

Brackets-Coder avatar Mar 31 '25 16:03 Brackets-Coder

@yuri-kiss I'm going to want you to review this eventually but let's not merge this until I get the HTML issues fixed, please and thank you so much

Brackets-Coder avatar Mar 31 '25 17:03 Brackets-Coder

!format

Brackets-Coder avatar Mar 31 '25 21:03 Brackets-Coder

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

github-actions[bot] avatar Mar 31 '25 21:03 github-actions[bot]

Why does Prettier remove the parentheses around the conditional part of ternary operators? it helps me read it better

Brackets-Coder avatar Mar 31 '25 21:03 Brackets-Coder

I guess this is acceptable enough now

I fixed some nitpicks with how HTML was formatted

Brackets-Coder avatar Mar 31 '25 21:03 Brackets-Coder

if you feel strongly about prettier's choices then you can talk to the prettier people about that but ensuring consistency and not having to really talk about style is sort of why we use it. it was a much larger problem when we were doing eslint rules instead and people would see 1000+ errors if they just used the wrong size tab

GarboMuffin avatar Apr 01 '25 21:04 GarboMuffin

@CubesterYT Want to review this?

Brackets-Coder avatar Apr 19 '25 20:04 Brackets-Coder

or @yuri-kiss

Brackets-Coder avatar Apr 19 '25 20:04 Brackets-Coder

let's not merge this yet though I have some questions

yuri-kiss avatar Apr 20 '25 18:04 yuri-kiss

let's not merge this yet though I have some questions

May I ask what those questions are?

Brackets-Coder avatar May 03 '25 15:05 Brackets-Coder

let's not merge this yet though I have some questions

May I ask what those questions are?

the one above for one

yuri-kiss avatar May 04 '25 01:05 yuri-kiss

let's not merge this yet though I have some questions

May I ask what those questions are?

the one above for one

As for the removed comment, it could go either way. To stay or not to stay? That is the question. It's up to you to answer. As for any other questions you might have, I might have an answer.

Brackets-Coder avatar May 04 '25 12:05 Brackets-Coder

happy to see this getting in

GarboMuffin avatar May 14 '25 03:05 GarboMuffin