desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Don't package flatpak release with full file system access

Open poly2it opened this issue 3 years ago • 7 comments

The flatpak app shouldn't have access to the full file system, as that may be exploited by vulnerabilities and makes the app lest trustworthy.

poly2it avatar Jan 14 '23 15:01 poly2it

I am not aware of how to make an Electron app be able to open files from argv without that permission

GarboMuffin avatar Jan 14 '23 17:01 GarboMuffin

I'm pretty sure it's possible; I just don't know how or if that's viable from Electron

GarboMuffin avatar Jan 14 '23 18:01 GarboMuffin

Some good news. We'll be getting rid of the full home access in the next update

GarboMuffin avatar Mar 07 '24 05:03 GarboMuffin

Welcome improvement. Thank you!

poly2it avatar Mar 08 '24 18:03 poly2it

The build was submitted to flathub. it'll probably show up within a few hours or so (update from the future: apparently removing permissions requires human review so it'll be longer than normal, but i've done all I can) (update 2: it's out)

GarboMuffin avatar Mar 10 '24 02:03 GarboMuffin

It turns out removing --filesystem=home breaks dragging & dropping files in

https://github.com/electron/electron/issues/30650

GarboMuffin avatar Mar 20 '24 04:03 GarboMuffin

I ended up adding --filesystem=home back because of the drag & drop problem

You can use Flatseal to manually remove it if you want. Everything else will still work

GarboMuffin avatar Apr 20 '24 02:04 GarboMuffin

It once again does not use --filesystem=home. To make the user experience not awful with drag and drop, the app still retains direct access to a few standard folders but it can't read your SSH keys anymore. Ironically this makes the list of scary red warnings even longer:

image

~~(the subtitle for com.discordapp.Discord is also wrong)~~

GarboMuffin avatar May 29 '24 08:05 GarboMuffin