intellij-emberjs
intellij-emberjs copied to clipboard
Turbo87
Add support for angle bracket components
to support e.g. https://github.com/rwjblue/ember-angle-bracket-invocation-polyfill
Any news on the progress of this? This is an integral part of Ember now and should be supported ASAP ;)
Thanks for the great plugin btw!
I've started investigating this in the last couple weeks and it seems we can't just reuse the HbsReferenceContributor as it's only handling the parsed handlebars tree.
Next I'll try to build a TagDescriptorsProvider which implements XmlElementDescriptorProvider, XmlTagNameProvider , similar to the ng2 implementation.
The intellij plugin docs are pretty lacking :(
nvm It's easier on ng2 side as they ship their own lexer
Sadly I didn't have any more time. I think the most sane solution would be to fork the handelbars plugin and extend their flex grammar to support what we need. This shouldn't be that much more work :tm: as we're already using the handlebars plugin parsing result.
Alternatively we could write our own gramma, similar to the ng2 plugin. That would be tons of work though :(
@makepanic I'm not sure why we need a custom grammer for this. I've tried to implement it using a regular ReferenceContributor, but for some reason the references were not clickable at all.
As much as I like developing in IntelliJ, writing plugins for it is a real pain in the ...
Interesting. I've tried to extend the HbsPatterns to get proper results but it seemed like i can only use the tokens that the handlebars library finds. Somehow i only got handlebars syntax and everything else was transparent. Don't we need access to the "html" tokens too (aka angle bracket tokens)?
yeah, the HbsReferenceContributor is limited to the Handlebars PSI. Angle Bracket Components are part of the HTML PSI though, so they would need their own dedicated reference contributor AFAICT.
Looks like this was added in https://github.com/Turbo87/intellij-emberjs/pull/293?
