aerofiles icon indicating copy to clipboard operation
aerofiles copied to clipboard

Made parsing of .cup files more generic regarding headers

Open moldhouse opened this issue 4 years ago • 4 comments

I had problems parsing a cup file downloaded from SeeYou cloud as the header rwwidth was included. Parsing now ignores columns that are not specified instead of throwing an error.

Sorry for the double quotes, this is due to auto formatting with black.

moldhouse avatar Nov 19 '20 12:11 moldhouse

looks like CI is unhappy about these changes 🙀

Turbo87 avatar Nov 19 '20 15:11 Turbo87

btw I'm fine with dropping support for older Python versions under a few minor conditions:

  • it should be done in a dedicated PR
  • we should mention it in the changelog
  • it should be released as a new major version since it's a breaking change

Turbo87 avatar Nov 19 '20 15:11 Turbo87

Okay, I have started to add type annotations to parts of the code base so requiring python 3.6 would certainly be beneficial.

moldhouse avatar Nov 19 '20 15:11 moldhouse

I think #217 tries to also implement rwwidth.

lordfolken avatar Apr 04 '21 07:04 lordfolken

Could you please change this PR, so that all changes of black are removed? Otherwise it is very hard to see, what you really have changed. Thanks!

bubeck avatar Oct 25 '23 18:10 bubeck

closed by https://github.com/Turbo87/aerofiles/pull/255

bubeck avatar Nov 17 '23 06:11 bubeck