SPX-GC icon indicating copy to clipboard operation
SPX-GC copied to clipboard

Some English language updates and corrections

Open mcnewton opened this issue 3 years ago • 3 comments

English is not a nice language, I'm sure :smile:. Make some corrections (especially e.g. "the" and use of plurals) and a few other updates to make things tidier, or change to more common usage.

I have this as a set of 38 individual commits if it would be helpful, instead of all in one.

mcnewton avatar Aug 05 '22 13:08 mcnewton

hello @mcnewton

thank for the review much appreciated, i would prefer the 38 individuals commit instead of one to make the review easier

bilbo-the-hobbit avatar Aug 05 '22 15:08 bilbo-the-hobbit

OK no worries! I'll update the PR shortly.

mcnewton avatar Aug 05 '22 15:08 mcnewton

That is a lot of lipstick :grin:. Hope it's clearer now.

mcnewton avatar Aug 05 '22 15:08 mcnewton

hello @mcnewton

thanks for this pr, sorry it take so long to act on it :) it's now merge into FusionDirectory 1.4

https://gitlab.fusiondirectory.org/fusiondirectory/fd/-/issues/6245

Cheers

bilbo-the-hobbit avatar Jan 10 '23 21:01 bilbo-the-hobbit